Ben's channel back in action! I have learned so much from you and everyone else at upcase. Will look forward to all your videos now. Thank you ben :)
@queuebit
7 жыл бұрын
I love the improvement with time on test failures, font size, and the slower speaking. I think v0 worked great in a familiar pairing situation; this one worked great for learning / following along with though processes / TDD.
@carlweis9848
7 жыл бұрын
Fantastic! Keep them coming. I'm a long time subscriber to upcase, and you are the main reason for watching. Can't wait for the next video. Thank You!!!
@ahmad_hamza
7 жыл бұрын
I really wanted this since long time. Thanks Ben for this.
@baernergiu
3 жыл бұрын
I really like breaking routes down into pure Rest. Only thing I would do different is not to use a service object, I think using `Refund.new(@order).run!` would be more readable with a "REST action" like `Refund.create(@order)`.
@danweavermedia
7 жыл бұрын
Great! This looks like it'll be a fantastic course. Good pace overall. The speech could be a little slower and the video could rest (geddit?) on the errors for a second longer. They're sometimes not on the screen long enough to locate and read. The font size is fine for me but the color scheme would benefit from higher contrast. When you highlight the error messages they become unreadable.
@r00k123123
7 жыл бұрын
Thanks for the feedback! I tweaked the color scheme and slowed down in future videos.
@mass13982
7 жыл бұрын
Awesome stuff Ben....What's your colorscheme?
@shvetsovdm
7 жыл бұрын
Ben, starting around 16:00 you jumping so fast back and forth between test results and the editor. We tend to do like that when working and know what to expect from test results it is natural behaviour. But when I watched this video I feel like "wait, wait, wait what is happening!". Perhaps it can be fixed by editing the video or by placing test results in a nearby window. Anyway, Ben, thanks for sharing the great video lesson and good luck with your rails course!
@r00k123123
7 жыл бұрын
Thanks for the feedback. I've slowed this down a bit in future screencasts.
@ChopperRichards
7 жыл бұрын
Love these videos, really good examples of some refactoring wins! As it stands, if you removed the call to Refund.run! the specs would still pass. Would you bother adding a test that the order was actually marked as refunded?
@JigneshKhokhani
6 жыл бұрын
I want know that can we not inherit refund controller from order controller as refund controller is child like controller fro order controller. Is it good practice to do this ? Same for user and admin controller. Please cam you suggest that is it good or not ?
Пікірлер: 12