Love those videos! Full of useful information and demonstrations about refactoring. Keep up with this good work!
@gregorriegler
4 жыл бұрын
thank you tom. i appreciate the feedback. i'm glad i can provide useful content while learning myself, and having fun at the same time.
@lucianosantillan164
4 жыл бұрын
Very good!
@kobac8207
4 жыл бұрын
Nice one Gregor! Also, I like to see your using Limited WIP plugin :) One small comment: I usually don't find value in appending Data to the name of the classes (InvoiceData -> Invoice). I find it redundant and communicates a bit more of a structure rather than domain concept and behavior. Cheers! Dragan Stepanović (not visible from my youtube account name :) )
@kobac8207
4 жыл бұрын
@Gregor Riegler not sure if I'd be calling this a data-only or a DTO, since we have a domain object Invoice, from which we're extracting all the data (customer, amount, credits) in order to create InvoiceData so we could pass it to a method which forms a string for printing. I'd expect DTO at the very "entrance" or "exit" from the domain and this DTO is in between two operations in domain (calculation and creating invoice text to print). We can notice that this forced us to expose both getters in Invoice and in InvoiceData. Perhaps I'd rather either pass Invoice to the plainTextPrinter method or actually move this logic to Invoice (one of the names for this method would be toPlainText for example). Latter one would remove all the getters as well as a side effect.
@dbaltor
Жыл бұрын
@@gregorriegler3280 Congrats for the video! I had the same question and ended up these days suffixing the domain objects with Entity or VO, and keeping the DTOs without suffix.
@bamboozled1696
3 жыл бұрын
This is truly merciless. Can you please share how are you saving in Intellij (disabling the auto save). And the special script for testing.
@gregorriegler
3 жыл бұрын
As of recent I am using the quarkus dev mode for Continuous Testing. It is just faster. Here is a simple bootstrap project with maven. github.com/gregorriegler/tdd-bootstrap-java-maven Just run the command in the readme. Everytime you save, it should automatically rerun the tests.
@TonyTigerTonyTiger
4 жыл бұрын
No mention of where you got the original code from? I recognize it from Martin Fowler's book (except you translated it to a different programming language).
@gregorriegler
4 жыл бұрын
good catch. you can find the link to the code in the desription (github.com/gregorriegler/refactoring-split-phase) and there i mention it.
Пікірлер: 10