Did your friend's ancestors know Abraham Lincoln's?
@SteveHook
3 жыл бұрын
😂
@GolangDojo
3 жыл бұрын
Hey. Stop using spaces
@gatsbatz5781
3 жыл бұрын
What's the right amount of time to spend on reviewing a PR, gents?!
@SteveHook
3 жыл бұрын
It depends, obviously the bigger and complex it is the more time you’ll spend. It you’re asking how much time before people say enough reviewing, start working. Probably not a serious company that puts accent on code quality
@segasieu
3 жыл бұрын
Code review should be fast, I do it with a check list such as: 1. Check compliance to the original ticket: The PR shouldn't do more than the scope of the task. 2. Look for obvious complexity issues: Big O 3. Check if some of the utility functions/classes can be taken from an external dependency. 4. In a multi-threaded environment check if the producer-consumer pattern is properly considered. 5. If a pattern is used check compliance. If none is used then check if one can be applied. All in all if it takes more than 15 minutes to review then the PR is too large or you're spending too much time on it. :)
@SteveHook
3 жыл бұрын
The majority of them yes agree. Some of them take longer than 15m if you put in the time and check, not to mention coming with good recommendations and changes, not just generic comments. Otherwise you end up, with fast code reviews and a bunch of hot fixes, due to fast CRs. A lot of the times, most of those checks pass, it’s looking for what can be improved or what test cases where not added or testing the real thing is what takes a bunch of time
Пікірлер: 11